Deprecate the Monitoring ingest settings

docs/reference/migration/migrate_7_16.asciidoc

@@ -11,6 +11,7 @@ See also <<release-highlights>> and <<es-release-notes>>.
 
 * <<breaking_716_ilm_changes>>
 
+* <<breaking_716_monitoring_changes>>
 
 //NOTE: The notable-breaking-changes tagged regions are re-used in the
 //Installation and Upgrade Guide
@@ -63,4 +64,36 @@ has been removed in 8.0.
 *Impact* +
 Update your ILM policies to remove the `freeze` action from the `cold` phase.
 ====
+
+[discrete]
+[[breaking_716_monitoring_changes]]
+==== Monitoring deprecations
+
+[[monitoring-use-ingest-setting-deprecation]]
+.The `use_ingest` setting on Monitoring exporter configurations is deprecated.
+[%collapsible]
+====
+*Details* +
+The `xpack.monitoring.exporters.*.use_ingest` property has been deprecated in 7.16.0 and
+will be removed in 8.0.0. This parameter controls the creation of pipelines for monitoring
+indices. These pipelines currently have no function.
+
+*Impact* +
+Discontinue the use of the `xpack.monitoring.exporters.*.use_ingest` setting.
+====
+
+[[monitoring-pipeline-master-timeout-setting-deprecation]]
+.The `index.pipeline.master_timeout` setting on Monitoring HTTP exporter configurations is deprecated.
+[%collapsible]
+====
+*Details* +
+The `xpack.monitoring.exporters.*.index.pipeline.master_timeout` property has been
+deprecated in 7.16.0. This parameter sets the timeout when waiting for the remote
+Monitoring cluster to create pipelines. These pipelines for monitoring indices currently
+have no function and will be removed in 8.0.0.
+
+*Impact* +
+Discontinue the use of the `xpack.monitoring.exporters.*.index.pipeline.master_timeout` setting.
+====
+
 // end::notable-breaking-changes[]

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/Exporter.java

@@ -89,7 +89,7 @@ public Iterator<Setting<?>> settings() {
      */
     public static final Setting.AffixSetting<Boolean> USE_INGEST_PIPELINE_SETTING =
             Setting.affixKeySetting("xpack.monitoring.exporters.","use_ingest",
-                    key -> Setting.boolSetting(key, true, Property.Dynamic, Property.NodeScope), TYPE_DEPENDENCY);
+                    key -> Setting.boolSetting(key, true, Property.Dynamic, Property.NodeScope, Property.Deprecated), TYPE_DEPENDENCY);
     /**
      * Every {@code Exporter} allows users to explicitly disable cluster alerts.
      */

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpExporter.java

@@ -389,7 +389,8 @@ public Iterator<Setting<?>> settings() {
      */
     public static final Setting.AffixSetting<TimeValue> PIPELINE_CHECK_TIMEOUT_SETTING =
             Setting.affixKeySetting("xpack.monitoring.exporters.","index.pipeline.master_timeout",
-                    (key) -> Setting.timeSetting(key, TimeValue.MINUS_ONE, Property.Dynamic, Property.NodeScope), HTTP_TYPE_DEPENDENCY);
+                    (key) -> Setting.timeSetting(key, TimeValue.MINUS_ONE, Property.Dynamic, Property.NodeScope, Property.Deprecated),
+                HTTP_TYPE_DEPENDENCY);
 
     /**
      * Minimum supported version of the remote monitoring cluster (same major).

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/ExportersTests.java

@@ -265,6 +265,10 @@ InitializedExporters initExporters(Settings settings) {
         assertEquals(settings.get("xpack.monitoring.exporters._name0.use_ingest"), "true");
         assertEquals(settings.get("xpack.monitoring.exporters._name1.type"), "http");
         assertEquals(settings.get("xpack.monitoring.exporters._name1.use_ingest"), "false");
+        assertWarnings("[xpack.monitoring.exporters._name0.use_ingest] setting was deprecated in Elasticsearch and will be removed " +
+            "in a future release! See the breaking changes documentation for the next major version.",
+            "[xpack.monitoring.exporters._name1.use_ingest] setting was deprecated in Elasticsearch and will be removed " +
+            "in a future release! See the breaking changes documentation for the next major version.");
     }
 
     public void testExporterBlocksOnClusterState() {

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpExporterTests.java

@@ -490,6 +490,11 @@ public void testCreateResources() {
 
         assertThat(uniqueOwners, hasSize(1));
         assertThat(uniqueOwners.get(0), equalTo("xpack.monitoring.exporters._http"));
+
+        if (useIngest == false) {
+            assertWarnings("[xpack.monitoring.exporters._http.use_ingest] setting was deprecated in Elasticsearch and will be removed " +
+                "in a future release! See the breaking changes documentation for the next major version.");
+        }
     }
 
     public void testCreateDefaultParams() {
@@ -526,6 +531,11 @@ public void testCreateDefaultParams() {
 
         // should have removed everything
         assertThat(parameters.size(), equalTo(0));
+
+        if (useIngest == false) {
+            assertWarnings("[xpack.monitoring.exporters._http.use_ingest] setting was deprecated in Elasticsearch and will be removed " +
+                "in a future release! See the breaking changes documentation for the next major version.");
+        }
     }
 
     public void testHttpExporterMigrationInProgressBlock() throws Exception {