[ML] Fix typo in ML shutdown test #77304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a small typo in elastic#77281 that made the test fail 2/9ths of the time. Fixes elastic#77297
droberts195
added
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
gwbrown
added a commit
that referenced
this pull request
Sep 7, 2021
This commit extends the `REPLACE` shutdown type to support a new `target_node_name` field, which will control the node used to replace the one that is to shut down. However, only the data layer is present as of this PR. Also adjusts the serialization/deserialization for the REPLACE type to handle mixed-version clusters. Also includes content of #77281 and #77304, follow-ups to the original PR which fix various test issues. Co-authored-by: David Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small typo in #77281 that made the test fail 2/9ths
of the time.
Fixes #77297