Adding a deprecation info API check for saml nameid_format setting #77276
Conversation
|
Pinging @elastic/es-data-management (Team:Data Management) |
| if (detailsList.isEmpty()) { | ||
| return null; | ||
| } else { | ||
| String message = "if nameid_format is not explicitly set, the previous default of " + |
There was a problem hiding this comment.
I think we either need some more text here or a section in the breaking release notes and link from here ( I think the latter gives us more flexibility ). I can open a PR for the docs and reference the logs here once we have a link
There was a problem hiding this comment.
Hi @jkakavas -- just confirming that this is still on your to-do list, and you're not waiting on anything from me.
There was a problem hiding this comment.
Thank you for the ping, you are right, this slipped my mind. I'll work on something today or tomorrow and get @lockewritesdocs to review.
There was a problem hiding this comment.
Thanks. I'll go ahead and merge this, and update its URL along with several others in an upcoming PR.
|
@elasticmachine update branch |
1 similar comment
|
@elasticmachine update branch |
jbaiera
left a comment
jbaiera
left a comment
There was a problem hiding this comment.
LGTM, pending results of the discussion about the docs
6 participants
In 8.0 the behavior of an unset saml nameid_format setting. This commit adds a check to the deprecation
info API that warns users of this change, if they are using saml without nameid_format being set.
Relates #42404 #44090