Adding deprecation info API check for misconfigured or ambiguous SSL settings #77092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
jbaiera
approved these changes
Sep 2, 2021
Member
jbaiera
left a comment
jbaiera
left a comment
There was a problem hiding this comment.
LGTM - Just one note about message wording that tripped my brain up.
| keystorePathSettingKey, keyPathSettingKey, certificatePathSettingKey, enabledSettingKey); | ||
| details.add(detail); | ||
| } else if (keystorePathSettingExists && keyPathSettingExists && certificatePathSettingExists) { | ||
| String detail = String.format(Locale.ROOT, "all of [%s], [%s], and [%s] are set. Only [%s] or [%s] and [%s] can be " + |
Member
There was a problem hiding this comment.
"x or y and z" scans a little strangely when reading for me. Maybe we rephrase to "Either x must be set or y and z must be set"
Member
Author
There was a problem hiding this comment.
I updated the wording to make it more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8.0 we prevent the server from starting up if certain SSL properties are misconfigured or ambiguous. Specifically:
This commit adds a check to the deprecation info API for these changes.
Relates #42404 #45892