Adding node deprecation info API check for frozen cache setting #77085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
jbaiera
approved these changes
Sep 2, 2021
Member
jbaiera
left a comment
jbaiera
left a comment
There was a problem hiding this comment.
LGTM, just a small question about the deprecation itself
| Setting<ByteSizeValue> cacheSizeSetting = Setting.byteSizeSetting(cacheSizeSettingKey, ByteSizeValue.ZERO); | ||
| if (cacheSizeSetting.exists(settings)) { | ||
| ByteSizeValue cacheSize = cacheSizeSetting.get(settings); | ||
| if (cacheSize.getBytes() > 0) { |
Member
There was a problem hiding this comment.
Just double checking here because I know that -1 usually means "disabled": Is this expected to be 0 or negative, or should it be always negative?
Member
Author
There was a problem hiding this comment.
On 8.0 it looks like we are not throwing an error if it is 0 -- https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/searchable-snapshots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/shared/FrozenCacheService.java#L128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8.0 the ability to have a positive "xpack.searchable.snapshot.shared_cache.size" on a non-frozen node
has been removed. This commit adds a deprecation info API check if a non-frozen node has a non-
negative "xpack.searchable.snapshot.shared_cache.size".
Relates #42404 #71013