EQL: Adjust the bwc tests for multi-value fields support after 7x merge #76846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behaviors in versions on or after 7.12.0
astefan
added
>bug
>test
elasticmachine
added
the
Team:QL (Deprecated)
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
astefan
changed the title
Contributor
Author
|
@Luegg I think it's these lines that should have been removed and the fact that at the test time it's likely the 7.x code being used in test didn't use the latest PR code. Not 100% sure, but from my tests now, that failure doesn't repro anymore. |
Luegg
approved these changes
Aug 24, 2021
Contributor
Luegg
left a comment
Luegg
left a comment
There was a problem hiding this comment.
Got it, thanks for elaborating 👍
This was referenced Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the test code after 7.x has the same code as well. Also, change one of the queries as the old version had issues on versions on or after 7.12.0.
Fixes #76618.
Fixes #76632.