Do not checksum on LZ4 compress #76666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use the custom lz4-block scheme when compressing data. This scheme automatically calculates and write a checksum when compressing. We do not actually read this checksum when decompressing so it is unnecessary. This commit resolves this by not writing a no-op checksum. This will break arbitrary decompressors. However, since the lz4 block format is not an official format anyway, this should be fine. Relates to elastic#73497/
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Aug 18, 2021
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Depending on benchmarks we may want this in 7.15 too.
Contributor
Author
Yeah. We can check back after a nightly or two. |
Tim-Brooks
added a commit
that referenced
this pull request
Aug 18, 2021
Currently we use the custom lz4-block scheme when compressing data. This scheme automatically calculates and write a checksum when compressing. We do not actually read this checksum when decompressing so it is unnecessary. This commit resolves this by not writing a no-op checksum. This will break arbitrary decompressors. However, since the lz4 block format is not an official format anyway, this should be fine. Relates to #73497.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the custom lz4-block scheme when compressing data. This
scheme automatically calculates and write a checksum when compressing.
We do not actually read this checksum when decompressing so it is
unnecessary. This commit resolves this by not writing a no-op checksum.
This will break arbitrary decompressors. However, since the lz4 block
format is not an official format anyway, this should be fine.
Relates to #73497.