Fix parsing of node shutdown allocation delay #76589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the parsing of allocation delay from XContent, which was previously completely broken. Also adjusts the tests to exercise that parsing.
gwbrown
added
>non-issue
v8.0.0
:Core/Infra/Node Lifecycle
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
dakrone
approved these changes
Aug 17, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, left one really minor comment
| nodeId, | ||
| SingleNodeShutdownMetadata.Type.parse((String) a[0]), | ||
| (String) a[1], | ||
| a[2] != null ? TimeValue.parseTimeValue((String) a[2], "put-shutdown-node-request-" + nodeId) : null |
Member
There was a problem hiding this comment.
Super minor nit to avoid double negatives:
Suggested change
| a[2] != null ? TimeValue.parseTimeValue((String) a[2], "put-shutdown-node-request-" + nodeId) : null | |
| a[2] == null ? null : TimeValue.parseTimeValue((String) a[2], "put-shutdown-node-request-" + nodeId) |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Aug 17, 2021
This commit fixes the parsing of allocation delay from XContent, which was previously completely broken. Also adjusts the tests to exercise that parsing.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2021
This commit fixes the parsing of allocation delay from XContent, which was previously completely broken. Also adjusts the tests to exercise that parsing. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the parsing of allocation delay from XContent, which
was previously completely broken. Also adjusts the tests to exercise
that parsing.
Follow-up to #75606