Print suggestion to view log on fatal error #75418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Elasticsearch fails to start up, it tries to print a message to suggest to the user that they consult the log for more information. However, if a fatal error is encounted, Elasticsearch exits directly and no such message is printed. Improve this situation by printing the same message when Elasticsearch is about to exit due to a fatal unexpected error.
pugnascotia
added
>enhancement
:Core/Infra/Resiliency
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pugnascotia
added a commit
that referenced
this pull request
Jul 21, 2021
Closes #61767. When Elasticsearch fails to start up, it tries to print a message to suggest to the user that they consult the log for more information. However, if a fatal error is encountered, Elasticsearch exits directly and no such message is printed. Improve this situation by printing the same message when Elasticsearch is about to exit due to a fatal unexpected error.
Contributor
Author
|
Backported to |
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
Closes elastic#61767. When Elasticsearch fails to start up, it tries to print a message to suggest to the user that they consult the log for more information. However, if a fatal error is encountered, Elasticsearch exits directly and no such message is printed. Improve this situation by printing the same message when Elasticsearch is about to exit due to a fatal unexpected error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61767.
When Elasticsearch fails to start up, it tries to print a message to
suggest to the user that they consult the log for more information.
However, if a fatal error is encounted, Elasticsearch exits directly and
no such message is printed.
Improve this situation by printing the same message when Elasticsearch
is about to exit due to a fatal unexpected error.