Remove SET aliases from disk usage and field usage YML tests #75381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
added
:Search/Search
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
elasticsearchmachine
added
the
external-contributor
dnhatn
removed
the
external-contributor
dnhatn
added
auto-merge-without-approval
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 15, 2021
…#75381) * Remove aliases from disk usage test * Remove aliases from field usage test
Collaborator
💚 Backport successful
|
stevejgordon
added a commit
that referenced
this pull request
Jul 15, 2021
…#75382) * Remove aliases from disk usage test * Remove aliases from field usage test Co-authored-by: Steve Gordon <[email protected]>
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
…#75381) * Remove aliases from disk usage test * Remove aliases from field usage test
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…#75381) * Remove aliases from disk usage test * Remove aliases from field usage test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @dnhatn, the clients team have YAML test runners for each client which exercise that client using the main Elasticsearch YML tests. The disk usage and field usage tests use an alias approach to simplify asserting on nested object values in the JSON. The client runners are unable to handle this use of the set operation and fail the tests.
This PR removes the use of aliases such that the tests should succeed in the client team tests.