Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 7, 2021

Adds formal API docs and JSON specs for the following APIs:

  • Get async SQL search
  • Get async SQL search status
  • Delete async SQL search

I plan to migrate some other existing APIs (SQL search, translate, clear cursor) to this page in a separate PR.

Closes #74845

Previews

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jul 7, 2021
@jrodewig
Copy link
Contributor Author

jrodewig commented Jul 7, 2021

@elasticmachine update branch

@jrodewig
Copy link
Contributor Author

jrodewig commented Jul 7, 2021

@elasticmachine update branch

@jrodewig jrodewig added :Analytics/SQL SQL querying >docs General docs changes v7.14.0 v7.15.0 labels Jul 7, 2021
@jrodewig jrodewig requested a review from bpintea July 7, 2021 21:17
@jrodewig jrodewig marked this pull request as ready for review July 7, 2021 21:17
@elasticmachine elasticmachine added Team:QL (Deprecated) Meta label for query languages team Team:Docs Meta label for docs team labels Jul 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig added the auto-backport Automatically create backport pull requests when merged label Jul 7, 2021
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

==== {api-query-parms-title}

`delimiter`::
(Optional, string) Separator for CSV results. Defaults to `,`. The API only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,51 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be clear that this is different from sql.query.json, but don't know if clear enough that all these are async SQL APIs. Up to you, not sure if there's a conversion about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bpintea. I used the same naming scheme we have for EQL:

However, I'll add async to the SQL versions so its a bit more clear.

@stevejgordon
Copy link
Contributor

LGTM!

@jrodewig
Copy link
Contributor Author

@elasticmachine ok to test

@jrodewig jrodewig merged commit a9ed7dc into elastic:master Jul 12, 2021
@jrodewig jrodewig deleted the docs__sql-apis branch July 12, 2021 14:12
@jrodewig jrodewig removed the auto-backport Automatically create backport pull requests when merged label Jul 12, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 12, 2021
Adds formal API docs and JSON specs for the following APIs:

* Get async SQL search
* Get async SQL search status
* Delete async SQL search

Closes elastic#74845
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 12, 2021
Adds formal API docs and JSON specs for the following APIs:

* Get async SQL search
* Get async SQL search status
* Delete async SQL search

Closes elastic#74845
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.14
7.x

elasticsearchmachine added a commit that referenced this pull request Jul 12, 2021
Adds formal API docs and JSON specs for the following APIs:

* Get async SQL search
* Get async SQL search status
* Delete async SQL search

Closes #74845

Co-authored-by: James Rodewig <[email protected]>
elasticsearchmachine added a commit that referenced this pull request Jul 12, 2021
Adds formal API docs and JSON specs for the following APIs:

* Get async SQL search
* Get async SQL search status
* Delete async SQL search

Closes #74845

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying >docs General docs changes Team:Clients Meta label for clients team Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.14.0 v7.15.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] SQL: Document async SQL search

7 participants