Json processor: add_to_root_conflict_strategy option #74967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
added
>enhancement
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
elasticsearchmachine
added
the
external-contributor
felixbarny
added
the
auto-backport
martijnvg
reviewed
Jul 7, 2021
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Left some comments.
@danhermann would also want to take a look at this pr?
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/JsonProcessor.java
Outdated
Show resolved
Hide resolved
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/JsonProcessor.java
Outdated
Show resolved
Hide resolved
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/JsonProcessor.java
Outdated
Show resolved
Hide resolved
danhermann
reviewed
Jul 7, 2021
Contributor
danhermann
left a comment
danhermann
left a comment
There was a problem hiding this comment.
Added some comments, primarily about naming, below. Naming is hard.
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/JsonProcessor.java
Outdated
Show resolved
Hide resolved
felixbarny
changed the title
Contributor
|
Thanks, LGTM. 👍 |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 8, 2021
Collaborator
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #74957
This is to support creating an ingest pipeline for ECS JSON logs.
Merging instead of
putAllis important as Filebeat sets values fordata_stream.type,data_stream.dataset, anddata_stream.namespace. If the logs override just one, such asdata_stream.dataset, currently, the wholedata_streamnamespace would be overridden.