-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix GeoIpProcessor when there's no updated db #74944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
probakowski
merged 5 commits into
elastic:master
from
probakowski:fix_geoip_with_no_custom_db
Jul 6, 2021
Merged
Fix GeoIpProcessor when there's no updated db #74944
probakowski
merged 5 commits into
elastic:master
from
probakowski:fix_geoip_with_no_custom_db
Jul 6, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
martijnvg
approved these changes
Jul 6, 2021
Member
martijnvg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 6, 2021
This change fixes problem with GeoIpProcessor when there's GeoIpTaskState present in the cluster state but there's no database matching the one used by the processor. It can happen when there are some but not all databases already updated.
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 6, 2021
This change fixes problem with GeoIpProcessor when there's GeoIpTaskState present in the cluster state but there's no database matching the one used by the processor. It can happen when there are some but not all databases already updated.
Collaborator
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 6, 2021
* Fix GeoIpProcessor when there's no updated db (#74944) This change fixes problem with GeoIpProcessor when there's GeoIpTaskState present in the cluster state but there's no database matching the one used by the processor. It can happen when there are some but not all databases already updated. * fix compilation Co-authored-by: Przemko Robakowski <[email protected]>
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 6, 2021
* Fix GeoIpProcessor when there's no updated db (#74944) This change fixes problem with GeoIpProcessor when there's GeoIpTaskState present in the cluster state but there's no database matching the one used by the processor. It can happen when there are some but not all databases already updated. * fix compilation Co-authored-by: Przemko Robakowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
>non-issue
Team:Data Management
Meta label for data/management team
v7.14.0
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes problem with
GeoIpProcessorwhen there'sGeoIpTaskStatepresent in the cluster state but there's no database matching the one used by the processor. It can happen when there are some but not all databases already updated.Marking it as non-issue as it's in code that hasn't been released yet.