Fix ExplainLifecycleIT.testExplainFilters #74941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain `onlyErrors` is tricky to integration test as all the ILM steps are now retryable (so the `explain` API might not catch a particular failing step when it's in the `ERROR` state as when we retry we move it back into the step that failed). This adds an unit test for the "explain onlyErrors" case.
andreidan
added
>test
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/rest-compatibility |
Contributor
Author
|
@elasticmachine update branch |
probakowski
approved these changes
Jul 6, 2021
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
LGTM 👍 thanks Andrei!
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Jul 6, 2021
Explain `onlyErrors` is tricky to integration test as all the ILM steps are now retryable (so the `explain` API might not catch a particular failing step when it's in the `ERROR` state as when we retry we move it back into the step that failed). This adds an unit test for the "explain onlyErrors" case. (cherry picked from commit 973610a) Signed-off-by: Andrei Dan <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 6, 2021
* Fix ExplainLifecycleIT.testExplainFilters (#74941) Explain `onlyErrors` is tricky to integration test as all the ILM steps are now retryable (so the `explain` API might not catch a particular failing step when it's in the `ERROR` state as when we retry we move it back into the step that failed). This adds an unit test for the "explain onlyErrors" case. (cherry picked from commit 973610a) Signed-off-by: Andrei Dan <[email protected]> * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain
onlyErrorsis tricky to integration test as all the ILM stepsare now retryable (so the
explainAPI might not catch a particularfailing step when it's in the
ERRORstate as when we retry we move itback into the step that failed).
This adds an unit test for the "explain onlyErrors" case.
Fixes #71010