Fix ActionConfigStatsTests.testEqualsAndHashcode #74849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
>test
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
probakowski
removed
the
auto-merge-without-approval
andreidan
approved these changes
Jul 5, 2021
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
Thanks for fixing this @probakowski
I think we can use the randomValueOtherThan method (note that the suggestion might fail formatting)
x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/ActionConfigStatsTests.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrei Dan <[email protected]>
Contributor
Author
|
@elasticmachine update branch |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 5, 2021
This change fixes failing ActionConfigStatsTests.testEqualsAndHashcode by making sure we use different shrink number of shards after mutation. Closes elastic#74817
Collaborator
💔 Backport failed
To backport manually run: |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jul 5, 2021
Additional fixes for `ActionConfigStatsTests.testEqualsAndHashcode` Relates to elastic#74849
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 5, 2021
This change fixes failing ActionConfigStatsTests.testEqualsAndHashcode by making sure we use different shrink number of shards after mutation. Closes #74817 Co-authored-by: Przemko Robakowski <[email protected]>
probakowski
added a commit
that referenced
this pull request
Jul 5, 2021
Additional fixes for `ActionConfigStatsTests.testEqualsAndHashcode` Relates to #74849
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 5, 2021
Additional fixes for `ActionConfigStatsTests.testEqualsAndHashcode` Relates to elastic#74849
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 5, 2021
Additional fixes for `ActionConfigStatsTests.testEqualsAndHashcode` Relates to #74849 Co-authored-by: Przemko Robakowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes failing
ActionConfigStatsTests.testEqualsAndHashcodeby making sure we use different shrink number of shards after mutation.Closes #74817