EQL: Remove "fields" section from sequence in-progress searches #74824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
costin
approved these changes
Jul 1, 2021
Member
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
👍
Let's keep an eye on the benchmarks to see what impact this PR will have (I expect things to improve slightly).
astefan
added
the
auto-backport
Luegg
approved these changes
Jul 5, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 5, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 5, 2021
This was referenced Jul 5, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 5, 2021
Collaborator
astefan
pushed a commit
that referenced
this pull request
Jul 6, 2021
astefan
pushed a commit
that referenced
this pull request
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now any
fieldsthe user was specifying in an eql request was carried over in any_searchrequest eql was performing, including intermediary searches as part of sequences. With this change, the unnecessary use offieldsinside in-progress searches from sequences is removed.Fixes #74582