Add filter support to data stream aliases #74784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
martijnvg
force-pushed
the
filtered_data_stream_aliases
branch
9 times, most recently
from
adba6c1 to
97a0523
Compare
This allows specifying a query as filter on data stream alias, which will then always be applied when searching via this alias. Relates elastic#66163
martijnvg
force-pushed
the
filtered_data_stream_aliases
branch
from
97a0523 to
5538576
Compare
martijnvg
added
:Data Management/Data streams
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
danhermann
approved these changes
Jul 6, 2021
Contributor
danhermann
left a comment
danhermann
left a comment
There was a problem hiding this comment.
LGTM. Minor non-blocking suggestion below.
| randomBoolean() ? randomFrom(dataStreams) : null | ||
| ); | ||
| randomBoolean() ? randomFrom(dataStreams) : null, | ||
| randomMap(1, 4, () -> new Tuple<>("term", Map.of("year", "2022")))); |
Contributor
There was a problem hiding this comment.
Maybe randomly create the alias without a filter?
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jul 20, 2021
Backporting elastic#74784 to 7.x branch. This allows specifying a query as filter on data stream alias, which will then always be applied when searching via this alias. Relates elastic#66163
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jul 21, 2021
martijnvg
added a commit
that referenced
this pull request
Jul 21, 2021
martijnvg
added a commit
that referenced
this pull request
Jul 21, 2021
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jul 21, 2021
martijnvg
added a commit
that referenced
this pull request
Jul 21, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 21, 2021
martijnvg
added a commit
that referenced
this pull request
Jul 21, 2021
Co-authored-by: Martijn van Groningen <[email protected]>
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
This allows specifying a query as filter on data stream alias, which will then always be applied when searching via this alias. Relates elastic#66163
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying a query as filter on data stream alias,
which will then always be applied when searching via this alias.
Relates #66163