Skip to content

Conversation

@BigPandaToo
Copy link
Contributor

Calculate SHA256 fingerprint for enrollment token

A follow up PR for:
#73573

@BigPandaToo BigPandaToo added >enhancement :Security/Security Security issues without another label v8.0.0 Team:Security Meta label for security team labels Jun 23, 2021
@BigPandaToo BigPandaToo requested a review from jkakavas June 23, 2021 18:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkakavas
Copy link
Contributor

Changed the label to non-issue because this is unreleased code

@BigPandaToo
Copy link
Contributor Author

@elasticmachine update branch

@jkakavas
Copy link
Contributor

You need to update your assertions as #72207 updated the httpCa.p12 that we use for the enrollment tests

@BigPandaToo
Copy link
Contributor Author

@elasticmachine update branch

@BigPandaToo BigPandaToo merged commit c37f9f1 into elastic:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Security/Security Security issues without another label Team:Security Meta label for security team v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants