Enhance Tests around SnapshotInfo UserMetadata #74362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We barely test the correct handling of user metadata directly. With upcoming changes to how `SnapshotInfo` is stored it would be nice to have better test coverage. This PR adds randomized coverage of serializing user metadata to a large number of tests that all user the shared infrastructure that is adjusted here.
original-brownbear
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
| throw new IllegalArgumentException("malformed metadata, should be an object"); | ||
| } | ||
| userMetadata((Map<String, Object>) entry.getValue()); | ||
| switch (name) { |
Contributor
Author
There was a problem hiding this comment.
Admittedly sort of unrelated but it took me longer than it should have to track down how SLM configures its snapshots via this method and this change makes things at least a little easier to read IMO.
Contributor
Author
|
Jenkins run elasticsearch-ci/part-2 (unrelated watcher tests) |
Contributor
Author
|
Thanks Francisco! |
Contributor
Author
|
relevant pieces from this one have been backported as part of #74676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We barely test the correct handling of user metadata directly.
With upcoming changes to how
SnapshotInfois stored it would be niceto have better test coverage. This PR adds randomized coverage of serializing
user metadata to a large number of tests that all user the shared infrastructure
that is adjusted here.