Fix HLRC compatibility with Java 8 #74290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional.isEmpty() was added in Java 11. In Java 8 we only have Optional.isPresent()
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
elasticsearchmachine
added
the
external-contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #73910
Removes the use of
Optional.isEmpty()that was added in Java 11. HLRC targets Java 8 where we only haveOptional.isPresent()This was caught by the
7.xbuild in the #74272 backport, but this check apparently isn't enforced inmaster. I opened #74289 to track this discrepancy.