Default index.shard.check_on_startup to false for searchable snapshots #74235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Jun 17, 2021
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks Tanguy, I left a couple of comments on the tests.
...sterTest/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsIntegTests.java
Outdated
Show resolved
Hide resolved
...st/java/org/elasticsearch/xpack/searchablesnapshots/FrozenSearchableSnapshotsIntegTests.java
Show resolved
Hide resolved
Member
Author
|
Thanks David! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jun 18, 2021
elastic#74235) Today a searchable snapshot index inherits the index.shard.check_on_startup index setting from the snapshot it is mounted from. But this setting can require some expensive processing as documented in elastic#74233, so we decided in elastic#73147 to default the value of this setting to false but allow the user to override this in the mount request. Closes elastic#73147
Contributor
|
I just realised we missed a bit of tidy-up here, with this change we no longer need to set |
Member
Author
|
I also noticed that we need to always set at least to I'll open a follow up |
Member
|
I raised #74282 since |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jun 18, 2021
Now the Mount API overrides the index.shard.check_on_startup setting value to false, there's no need for MountSnapshotStep to set it explicitly. Backport of elastic#74283 Relates elastic#74235
tlrx
added a commit
that referenced
this pull request
Jun 18, 2021
…apshots (#74279) Today a searchable snapshot index inherits the index.shard.check_on_startup index setting from the snapshot it is mounted from. But this setting can require some expensive processing as documented in #74233, so we decided in #73147 to default the value of this setting to false but allow the user to override this in the mount request. Backport of #74235 Closes #73147
tlrx
added a commit
that referenced
this pull request
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a searchable snapshot index inherits the
index.shard.check_on_startupindex setting from the snapshot it is mounted from. But this setting can require some expensive processing as documented in #74233, so we decided in #73147 to default the value of this setting tofalsebut allow the user to override this in the mount request.Closes #73147
Note to reviewer: I don't see this as a breaking change neither I think it should deserve a mention in the Mount API as the setting is "expert only", so I did not update documentation. Let me know if you think I should.