Cache API key hashing results on creation time (#74106) #74161
Merged
+57
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API key hashing result is now cached on the creation time of an API key, i.e. pre-warm the cache. Previously it is cached when the API key is authenticated for the first time. Since it is reasonable to assume that an API key will be used shortly after its creation, this change has following advantages: * It removes the need for expensive pbkdf2 hashing computation on authentication time and therefore reduces overall server load * It makes the first authentication faster We expect all keys to be used, that is, caching on creation time does not change the total number of keys need to be cached. Hence this PR does not introduce any extra logic to fine tune whether a key should be cached (for example, only cache if the load factor is lower than certain threshold etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API key hashing result is now cached on the creation time of an API key,
i.e. pre-warm the cache. Previously it is cached when the API key is
authenticated for the first time. Since it is reasonable to assume that an API
key will be used shortly after its creation, this change has following
advantages:
authentication time and therefore reduces overall server load
We expect all keys to be used, that is, caching on creation time does not
change the total number of keys need to be cached. Hence this PR does not
introduce any extra logic to fine tune whether a key should be cached (for
example, only cache if the load factor is lower than certain threshold etc.).