Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jun 15, 2021

Changes:

  • Notes that Elasticsearch doesn't apply index templates to cloned indices.
  • Notes the clone API doesn't copy index settings.

Closes #74135

Preview

https://elasticsearch_74138.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/indices-clone-index.html#clone-index-api-desc

Changes:
* Notes that Elasticsearch doesn't apply index templates to cloned indices.
* Notes the clone API doesn't copy index settings.
@jrodewig jrodewig marked this pull request as ready for review June 15, 2021 16:36
@jrodewig jrodewig added :Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes v7.13.3 v7.14.0 v8.0.0 labels Jun 15, 2021
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Jun 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig requested a review from DaveCTurner June 15, 2021 16:37
@jrodewig jrodewig added the :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Jun 15, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 48a8405 into elastic:master Jun 15, 2021
@jrodewig jrodewig deleted the docs__clarify-clone-index-settings branch June 15, 2021 20:38
jrodewig added a commit that referenced this pull request Jun 15, 2021
) (#74152)

Changes:
* Notes that Elasticsearch doesn't apply index templates to cloned indices.
* Notes the clone API doesn't copy index settings.
jrodewig added a commit that referenced this pull request Jun 15, 2021
) (#74153)

Changes:
* Notes that Elasticsearch doesn't apply index templates to cloned indices.
* Notes the clone API doesn't copy index settings.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 16, 2021
In elastic#74138 we noted that index settings aren't copied in a clone. In fact
that's not true, we copy everything except explicitly-excluded ones,
`number_of_replicas` and `auto_expand_replicas`. This fixes the mistake.
DaveCTurner added a commit that referenced this pull request Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact
that's not true, we copy everything except explicitly-excluded ones,
`number_of_replicas` and `auto_expand_replicas`. This fixes the mistake.

Co-authored-by: James Rodewig <[email protected]>
DaveCTurner added a commit that referenced this pull request Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact
that's not true, we copy everything except explicitly-excluded ones,
`number_of_replicas` and `auto_expand_replicas`. This fixes the mistake.

Co-authored-by: James Rodewig <[email protected]>
DaveCTurner added a commit that referenced this pull request Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact
that's not true, we copy everything except explicitly-excluded ones,
`number_of_replicas` and `auto_expand_replicas`. This fixes the mistake.

Co-authored-by: James Rodewig <[email protected]>
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Indices APIs APIs to create and manage indices and templates :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes Team:Data Management Meta label for data/management team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.13.3 v7.14.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clone index does not keep "number_of_replicas" setting, nor it respects index templates

4 participants