Skip to content

[7.x] Fix mapping error to indicate values field (#74132) #74137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[7.x] Fix mapping error to indicate values field (#74132) #74137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb2b0f1
Fix mapping error to indicate values field (#74132)
benwtrent Jun 15, 2021
e795c86
fixing regex
benwtrent Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nalytics/src/main/java/org/elasticsearch/xpack/analytics/mapper/HistogramFieldMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ public void parse(ParseContext context) throws IOException {
if (val < previousVal) {
// values must be in increasing order
throw new MapperParsingException("error parsing field ["
+ name() + "], ["+ COUNTS_FIELD + "] values must be in increasing order, got [" + val +
+ name() + "], ["+ VALUES_FIELD + "] values must be in increasing order, got [" + val +
"] but previous value was [" + previousVal +"]");
}
values.add(val);
Expand Down
8 changes: 7 additions & 1 deletion x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/analytics/histogram.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,13 @@ setup:
- '{"latency": {"values" : [0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6]}}'
- '{"index": {}}'
- '{"latency": {"values" : [0, 0.1, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 2, 5, 10, 1, 8]}}'

---
"Histogram requires values in increasing order":
- do:
catch: /error parsing field \[latency\], \[values\] values must be in increasing order/
index:
index: test
body: {"latency": {"values" : [1.0, 0.2, 0.3, 0.4, 0.5], "counts" : [3, 7, 23, 12, 6]}}
---
"Histogram Aggregations":

Expand Down