Skip to content

Conversation

@original-brownbear
Copy link
Contributor

Drying up a few spots of code duplication with these tests, both within them (listener handling) and across snapshot tests + other snapshot integ tests.
Partly done to reduce the size of PR #73952 that makes use of the smoke test infrastructure.

Drying up a few spots of code duplication with these tests. Partly to
reduce the size of PR elastic#73952 that makes use of the smoke test infrastructure.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.14.0 labels Jun 9, 2021
@elasticmachine elasticmachine added Team:Delivery Meta label for Delivery team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Jun 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@original-brownbear
Copy link
Contributor Author

Thanks Francisco!

@original-brownbear original-brownbear merged commit 38fa7b7 into elastic:master Jun 10, 2021
@original-brownbear original-brownbear deleted the drier-snapshot-http-smoke-stuff branch June 10, 2021 07:43
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jun 13, 2021
Drying up a few spots of code duplication with these tests. Partly to
reduce the size of PR elastic#73952 that makes use of the smoke test infrastructure.
original-brownbear added a commit that referenced this pull request Jun 13, 2021
Drying up a few spots of code duplication with these tests. Partly to
reduce the size of PR #73952 that makes use of the smoke test infrastructure.
@original-brownbear original-brownbear restored the drier-snapshot-http-smoke-stuff branch April 18, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Delivery Meta label for Delivery team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.14.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants