Rename o.e.common in libs/core to o.e.core #73909
Conversation
When libs/core was created, several classes were moved from server's o.e.common package, but they were not moved to a new package. Split packages need to go away long term, so that Elasticsearch can even think about modularization. This commit moves all the classes under o.e.common in core to o.e.core. relates elastic#73784
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Note that the classes here are rarely changed, so the possibility for create backport conflicts should be low. I think we can backport this to 7.x, and if for some reason a change is needed in 7.13 to one of these classes, that can be handled manually if the rename is not picked up in the cherry pick. |
|
In a lot of cases I find that git's rename detection and handling for merges/cherry-picks is pretty good so it's probably not too much of a concern. |
o.e.common package, but they were not moved to a new package. Split packages need to go away long term, so that Elasticsearch can even think about modularization. This commit moves all the classes under o.e.common in core to o.e.core. relates elastic#73784 backport elastic#73909
When libs/core was created, several classes were moved from server's o.e.common package, but they were not moved to a new package. Split packages need to go away long term, so that Elasticsearch can even think about modularization. This commit moves all the classes under o.e.common in core to o.e.core. relates #73784 backport #73909
|
When upgrading the HLClient to 7.14.0, this is breaking my project as the I see several options:
|
|
@dadoonet We discussed this in the core/infra sync and decided to do nothing here (your option 1). As you pointed out, the change is trivial. Additionally, there has always been an expectation for HL Client (and transport client and plugins) that because they depend on the server jar, there is always the possibility of needing compile changes on upgrades. |
… no deprecation of the old class, see elastic/elasticsearch#73909 Signed-off-by: Håvard Ottestad <[email protected]>
|
This broke our code by stopping users from upgrading their own code to use a newer minor version of Elasticsearch than the one we are depending on (7.8.1). |
… no deprecation of the old class, see elastic/elasticsearch#73909 Signed-off-by: Håvard Ottestad <[email protected]>
6 participants
When libs/core was created, several classes were moved from server's
o.e.common package, but they were not moved to a new package. Split
packages need to go away long term, so that Elasticsearch can even think
about modularization. This commit moves all the classes under o.e.common
in core to o.e.core.
relates #73784