Skip to content

Fix eclipse for build tools (#73699) (7.x backport) #73904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2021
Merged

Fix eclipse for build tools (#73699) (7.x backport) #73904

merged 2 commits into from
Jun 8, 2021

Conversation

@breskeby
Copy link
Contributor

@breskeby breskeby commented Jun 8, 2021

backports #73699 to fix-eclipse-for-build-tools-7.x branch

@breskeby
Fix eclipse for build tools (elastic#73699)
fa7befe 
apply common eclipse config to all projects across the elasticsearch workspace
including build tools projects
@breskeby breskeby added :Delivery/Build Build or test infrastructure backport v7.14.0 labels Jun 8, 2021
@breskeby breskeby self-assigned this Jun 8, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jun 8, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 8, 2021

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added the >bug label Jun 8, 2021
@breskeby breskeby merged commit 3799abc into elastic:7.x Jun 8, 2021
@breskeby breskeby deleted the fix-eclipse-for-build-tools-7.x branch June 8, 2021 14:37
@mark-vieira
Copy link
Contributor

mark-vieira commented Jun 9, 2021

This caused a strange error when importing the build into IntelliJ. I think the issue being that buildSrc still exists in 7.x but not master. I think we'll need to backport the removal of buildSrc before this. Or fix whatever the root cause is...

Build file '/Users/tim/Development/Projects/elasticsearch-other/elasticsearch-7.x/build-tools/build.gradle' line: 31
A problem occurred evaluating project ':build-tools'.
> Failed to apply plugin 'elasticsearch.eclipse'.
   > Cannot configure eclipse
...
Caused by: java.io.FileNotFoundException: File '/Users/tim/Development/Projects/elasticsearch-other/elasticsearch-7.x/buildSrc/build-tools-internal/src/main/resources/license-headers/sspl+elastic-license-header.txt' does not exist

For now I've reverted this change in 7.x.

mark-vieira added a commit that referenced this pull request Jun 9, 2021
@mark-vieira
Revert "Fix eclipse for build tools (#73699) (7.x backport) (#73904)"
edd9597 
This reverts commit 3799abc
breskeby added a commit that referenced this pull request Jun 9, 2021
@breskeby
Revert "Revert "Fix eclipse for build tools (#73699) (7.x backport) (#…
f5ec26d 
…73904)""

This reverts commit edd9597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@breskeby breskeby

Labels

backport >bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@breskeby @elasticmachine @mark-vieira