-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix java compatibility for build-tools-internal #73897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix java compatibility for build-tools-internal #73897
Conversation
- should be 11 not 15
|
Pinging @elastic/es-delivery (Team:Delivery) |
Luegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this solved the issue for me and I can now import the checkstyle config without error. Thanks a lot!
|
@breskeby this was purposefully changed to use the compiler java home. The intention there was that since this is "internal" it should just use the same compiler version as Gradle, and that way we can use newer APIs in our build code. In fact #73784 depends on it. I think the original reported issue about checkstyle is due to the fact that the IDE itself is executing that code and it's using a Java 11 IDE. Maybe we should split that stuff out somehow or throw it into one of the other existing projects that are Java 11 compatible? |
|
Ah I see. It looked like I accidentally changed that when porting to build tools internal |
|
I'll revert this and follow up with @Luegg on the origin of his local problem |
|
reverted |
|
We still need a solution here. I ran into this issue locally. |
This was accidentally set to 15.