Skip to content

Conversation

@breskeby
Copy link
Contributor

@breskeby breskeby commented Jun 8, 2021

This was accidentally set to 15.

  • should be 11 not 15 taken from the minimumRuntimeVersion file and not from minimumCompilerVersion
  • this also fixes the checkstyle ides setup

@breskeby breskeby self-assigned this Jun 8, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.14.0 v8.0.0 labels Jun 8, 2021
@breskeby breskeby requested a review from Luegg June 8, 2021 13:11
@breskeby breskeby marked this pull request as ready for review June 8, 2021 13:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@Luegg Luegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this solved the issue for me and I can now import the checkstyle config without error. Thanks a lot!

@breskeby breskeby added >bug and removed v7.14.0 labels Jun 8, 2021
@breskeby breskeby merged commit e655772 into elastic:master Jun 8, 2021
@breskeby breskeby deleted the fix-build-tools-internal-compatibility branch June 8, 2021 14:01
@mark-vieira
Copy link
Contributor

mark-vieira commented Jun 8, 2021

@breskeby this was purposefully changed to use the compiler java home. The intention there was that since this is "internal" it should just use the same compiler version as Gradle, and that way we can use newer APIs in our build code. In fact #73784 depends on it.

I think the original reported issue about checkstyle is due to the fact that the IDE itself is executing that code and it's using a Java 11 IDE. Maybe we should split that stuff out somehow or throw it into one of the other existing projects that are Java 11 compatible?

@breskeby
Copy link
Contributor Author

breskeby commented Jun 8, 2021

Ah I see. It looked like I accidentally changed that when porting to build tools internal

@breskeby
Copy link
Contributor Author

breskeby commented Jun 8, 2021

I'll revert this and follow up with @Luegg on the origin of his local problem

breskeby added a commit that referenced this pull request Jun 8, 2021
@breskeby
Copy link
Contributor Author

breskeby commented Jun 8, 2021

reverted

@mark-vieira
Copy link
Contributor

We still need a solution here. I ran into this issue locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants