Identify cancelled tasks in list tasks API #72931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `cancelled` flag to each cancellable task in the response to the list tasks API, allowing users to see that a task has been properly cancelled and will complete as soon as possible. Closes elastic#72907
DaveCTurner
added
>enhancement
:Distributed Coordination/Task Management
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
approved these changes
May 11, 2021
| POST _tasks/_cancel?nodes=nodeId1,nodeId2&actions=*reindex | ||
| -------------------------------------------------- | ||
|
|
||
| A task may continue to run for some time after it has been cancelled because it |
tlrx
approved these changes
May 17, 2021
Member
tlrx
left a comment
tlrx
left a comment
There was a problem hiding this comment.
LGTM, this is the kind of small changes that makes everyone's life easier 👍
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 17, 2021
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 17, 2021
Adjusts wire-compat and re-enables BWC tests
Contributor
Author
|
Thanks both! |
DaveCTurner
added a commit
that referenced
this pull request
May 17, 2021
This commit adds a `cancelled` flag to each cancellable task in the response to the list tasks API, allowing users to see that a task has been properly cancelled and will complete as soon as possible. Closes #72907
DaveCTurner
added a commit
that referenced
this pull request
May 17, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
cancelledflag to each cancellable task in theresponse to the list tasks API, allowing users to see that a task has
been properly cancelled and will complete as soon as possible.
Closes #72907