Add REST API specification for SAML APIs #72839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates: #67189
jkakavas
added
:Security/Security
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Member
|
There is also RestSamlCompleteLogoutAction. But this API does not have documentation either. It's probably an oversight of the original PR. I can raise a separate PR for both its PR and rest api sepc. |
| "stability":"stable", | ||
| "visibility":"public", | ||
| "headers":{ | ||
| "accept": [ "application/json"] |
Contributor
There was a problem hiding this comment.
"content_type": ["application/json"]
I don't know if this is used (idem the rest).
| "GET" | ||
| ], | ||
| "parts":{ | ||
| "name":{ |
Contributor
There was a problem hiding this comment.
Should be realm_name instead of name.
albertzaharovits
approved these changes
May 30, 2021
sethmlarson
suggested changes
May 30, 2021
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Handful of nits and thoughts for you!
rest-api-spec/src/main/resources/rest-api-spec/api/security.saml_invalidate.json
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/security.saml_prepare_authentication.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/security.saml_sp_metadata.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/security.saml_sp_metadata.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/security.saml_authenticate.json
Outdated
Show resolved
Hide resolved
sethmlarson
approved these changes
Jun 21, 2021
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 24, 2021
These API specifications were originally not added as we considered them internal.
jkakavas
added a commit
that referenced
this pull request
Jun 24, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: elastic/elasticsearch-specification#3753