SQL: Introduce an async querying mode for SQL #72166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an async query mode to SQL. It (re)uses the same request and response async-specific EQL object parameters. Also similar to EQL, the running search task can have its state monitored and canceled and its results sored and deleted, with intermediary responses not supported (the entire result is available once search finished). The initial query and subsequent pagination/scrolling requests will both be started in the asyn mode.
Use sane/safe async default values.
- integration testing missing still.
Abstract reusable transport plugin code where feasible. (cherry picked from commit 8d5cef141c3a823f28cae6321e4859125c1c1624)
Add ability to cancel ongoing SQL query task. Add the async integration tests.
Remove superfluous expected call.
This provides the task ID into the SqlQueryResponse also when building this for a cursor-based request (not just query-based one).
This extends the async implementation to support working with the text formats (txt, csv, tsv).
No format spec'ing now throws an exception, adapt to that.
Contributor
Author
|
Closing in favour of chunking down into a feature-branch. Superseded by #73267. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an async query mode to SQL.
It (re)uses the same request and response async-specific EQL object
parameters.
Also similar to EQL, the running search task can have its state
monitored and canceled and its results stored and deleted, with
intermediary responses not supported (the entire result is available
once search finished).
The initial query and subsequent pagination/scrolling requests will both
be started in the async mode.