Change script context names for run time fields to type_field #71581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
@nik9000 Thanks for the review and extra help! I will commit as soon as CI passes. |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Apr 12, 2021
…c#71581) This changes all the script context names specifically for runtime fields to be *_field such as long_field and geo_point_field, etc. This change is internal detail that will only be exposed through the Painless execute API as part of (elastic#71374) and should not have bwc issues. I tested this change locally on a mixed cluster to ensure scripts stored with the old runtime fields context names are both still retrievable and delete-able. This works because the context name is only used during the request to check for valid compilation, but never actually stored as part of the cluster state.
jdconrad
added a commit
that referenced
this pull request
Apr 12, 2021
#71586) This changes all the script context names specifically for runtime fields to be *_field such as long_field and geo_point_field, etc. This change is internal detail that will only be exposed through the Painless execute API as part of (#71374) and should not have bwc issues. I tested this change locally on a mixed cluster to ensure scripts stored with the old runtime fields context names are both still retrievable and delete-able. This works because the context name is only used during the request to check for valid compilation, but never actually stored as part of the cluster state.
Member
|
thanks @jdconrad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all the script context names specifically for runtime fields to be *_field such as
long_fieldandgeo_point_field, etc. This change is internal detail that will only be exposed through the Painless execute API as part of (#71374) and should not have bwc issues. I tested this change locally on a mixed cluster to ensure scripts stored with the old runtime fields context names are both still retrievable and delete-able. This works because the context name is only used during the request to check for valid compilation, but never actually stored as part of the cluster state.