Skip to content

Conversation

@astefan
Copy link
Contributor

@astefan astefan commented Apr 8, 2021

Fixes #71442 by changing the runtime that was initially used (day name) to a more H2-friendly one: a string concatenation.

@astefan astefan added >bug >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying v8.0.0 v7.13.0 labels Apr 8, 2021
@astefan astefan requested review from bpintea, costin and matriv April 8, 2021 23:41
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Apr 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan merged commit a46c1d6 into elastic:master Apr 12, 2021
@astefan astefan deleted the 71442_fix branch April 12, 2021 11:25
astefan added a commit to astefan/elasticsearch that referenced this pull request Apr 12, 2021
Change the runtime field used in tests to overcome H2's locale dependent implications in certain date/time related queries

(cherry picked from commit a46c1d6)
astefan added a commit that referenced this pull request Apr 12, 2021
Change the runtime field used in tests to overcome H2's locale dependent implications in certain date/time related queries

(cherry picked from commit a46c1d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v7.13.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] JdbcSqlSpecIT testWildcardWithLimit: Different result for column [birth_date_day_of_week]

6 participants