-
Notifications
You must be signed in to change notification settings - Fork 25.6k
SQL: Change the runtime field script for IT tests #71512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
implications in certain date/time related queries
|
Pinging @elastic/es-ql (Team:QL) |
bpintea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
matriv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
costin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change the runtime field used in tests to overcome H2's locale dependent implications in certain date/time related queries (cherry picked from commit a46c1d6)
Fixes #71442 by changing the runtime that was initially used (day name) to a more H2-friendly one: a string concatenation.