REST API compat testing - remove the requirement for default distro #71119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 958fc38.
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally much of the REST API compatibility code was to live in
x-pack. However, some design changes has removed this requirements
and there is no longer a need to explicitly use the default distribution
for REST API compatibility testing.
If using the default distribution AND applying the modules for test clusters (as is the default) then there can be server errors such as mapping types already registered. If we had kept with the original design we would need to figure out how to conditionally add modules...but now we can simply remove this special requirement.