Improve data stream rollover and simplify cluster metadata validation for data streams #70934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etadata no longer attempts to ensure that indices or aliases cannot conflict with future backing index names for data streams
danhermann
added
>enhancement
v8.0.0
:Data Management/Data streams
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
Author
|
@martijnvg, the main part of this change is in the first commit. The second commit moves |
martijnvg
approved these changes
Mar 29, 2021
| long currentTimeMillis = timeProvider.getAsLong(); | ||
| do { | ||
| newWriteIndexName = DataStream.getDefaultBackingIndexName(getName(), ++generation, currentTimeMillis); | ||
| } while (clusterMetadata.getIndicesLookup().containsKey(newWriteIndexName)); |
Member
There was a problem hiding this comment.
👍 simple and nicely encapsulated in this method
Contributor
Author
|
Thanks, @martijnvg! |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Mar 29, 2021
… for data streams (elastic#70934)
This was referenced Mar 29, 2021
Merged
[7.12] Improve data stream rollover and simplify cluster metadata validation for data streams
#70999
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a naming conflict for a new write index is detected when a data stream rolls over, it will now increment its own generation until the new write index's name does not conflict with any other indices, aliases, or data streams. This allows us to remove the trappy validation around name conflicts for the backing indices of data streams.
Fixes #70905.