Support fetching flattened subfields #70916
Conversation
Currently the `fields` API fetches the root flattened field and returns it in a structured way in the response. In addition this change makes it possible to directly query subfields. However, requesting flattened subfields via wildcard patterns is not possible. Closes elastic#70605
cbuescher
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
server/src/main/java/org/elasticsearch/index/mapper/FieldTypeLookup.java
Show resolved
Hide resolved
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
I think this is generally the right way to go - left a couple of comments.
server/src/main/java/org/elasticsearch/index/mapper/flattened/FlattenedFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/FieldTypeLookup.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me, just left some small suggestions.
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/flattened/FlattenedFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/mapper/flattened/KeyedFlattenedFieldTypeTests.java
Show resolved
Hide resolved
|
@jtibshirani thanks, I think I adressed your change requests and added a unit and a yaml test. I think I will also add a short passage to the docs somewhere about fetching flattened subfields and that the naming has to be exact, I haven't found a good spot yet though. Will be back with another short update shortly. |
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me! I added some last minor comments.
|
|
||
| [discrete] | ||
| [[search-fields-flattened]] | ||
| ==== Handling of flattened fields |
There was a problem hiding this comment.
It would be nice to move this to the flattened field type documentation. That would help keep this high-level documentation streamlined and easy to approach.
| } | ||
|
|
||
| @Override | ||
| public ValueFetcher valueFetcher(SearchExecutionContext context, String format) { |
There was a problem hiding this comment.
I just realized we should throw an error if the format is non-null, as we do for most other field types. (This is unfortunately very manual right now and easy to forget...)
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, thanks for the iterations @cbuescher
Currently the `fields` API fetches the root flattened field and returns it in a structured way in the response. In addition this change makes it possible to directly query subfields. However, requesting flattened subfields via wildcard patterns is not possible. Closes elastic#70605
Currently the `fields` API fetches the root flattened field and returns it in a structured way in the response. In addition this change makes it possible to directly query subfields. However, requesting flattened subfields via wildcard patterns is not possible. Closes #70605
5 participants
Currently the
fieldsAPI fetches the root flattened field and returns it in astructured way in the response. In addition this change makes it possible to
directly query subfields. However, requesting flattened subfields via wildcard
patterns is not possible.
Closes #70605