GeoIpDownloaderIT should be able to reuse test clusters and #70640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run tests against a test cluster with multiple nodes.
martijnvg
added
>non-issue
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Member
Author
|
@elasticmachine update branch |
probakowski
approved these changes
Mar 24, 2021
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
LGTM 👍 one super minor nit
Comment on lines
240
to
241
Contributor
There was a problem hiding this comment.
this should fit in single line
martijnvg
force-pushed
the
iter_GeoIpDownloaderIT
branch
from
27d19ea to
339ab0d
Compare
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 24, 2021
GeoIpDownloaderIT should be able to reuse test clusters and run tests against a test cluster with multiple nodes.
martijnvg
added a commit
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run tests against a test cluster with multiple nodes.