SQL: Fix handling of nested minuses #70555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the parentCtx checks on a unary arithmetic expression stopped too early, resulting in wrong handling of nested minuses. Use a while loop to reach the top level unary arithmetic expression and count the number of minuses, an odd count means an acutal negation. Fixes: elastic#66145
elasticmachine
added
the
Team:QL (Deprecated)
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Mar 19, 2021
Previously, the parentCtx checks on a unary arithmetic expression stopped too early, resulting in wrong handling of nested minuses. Use a while loop to reach the top level unary arithmetic expression and count the number of minuses, an odd count means an acutal negation. Fixes: elastic#66145 (cherry picked from commit db2cd3a)
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Mar 19, 2021
Previously, the parentCtx checks on a unary arithmetic expression stopped too early, resulting in wrong handling of nested minuses. Use a while loop to reach the top level unary arithmetic expression and count the number of minuses, an odd count means an acutal negation. Fixes: elastic#66145 (cherry picked from commit db2cd3a)
matriv
added a commit
that referenced
this pull request
Mar 19, 2021
Previously, the parentCtx checks on a unary arithmetic expression stopped too early, resulting in wrong handling of nested minuses. Use a while loop to reach the top level unary arithmetic expression and count the number of minuses, an odd count means an acutal negation. Fixes: #66145 (cherry picked from commit db2cd3a)
matriv
added a commit
that referenced
this pull request
Mar 19, 2021
Previously, the parentCtx checks on a unary arithmetic expression stopped too early, resulting in wrong handling of nested minuses. Use a while loop to reach the top level unary arithmetic expression and count the number of minuses, an odd count means an acutal negation. Fixes: #66145 (cherry picked from commit db2cd3a)
matriv
added a commit
that referenced
this pull request
Mar 19, 2021
Previously, the parentCtx checks on a unary arithmetic expression stopped too early, resulting in wrong handling of nested minuses. Use a while loop to reach the top level unary arithmetic expression and count the number of minuses, an odd count means an acutal negation. Fixes: #66145 (cherry picked from commit db2cd3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parentCtx checks on a unary arithmetic expression
stopped too early, resulting in wrong handling of nested minuses.
Use a while loop to reach the top level unary arithmetic expression
and count the number of minuses, an odd count means an acutal negation.
Fixes: #66145