Skip to content

Conversation

@talevy
Copy link
Contributor

@talevy talevy commented Mar 17, 2021

this commit adds support for aggregate_metric_double fields
in the RollupShardIndexer.

Previously, rollups of rollups were failing because the indexer
did not know how to fetch field values for aggregate metric fields and
the respective _doc_count fields

@talevy talevy added >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v8.0.0 v7.13.0 labels Mar 17, 2021
@talevy talevy requested a review from csoulios March 17, 2021 23:18
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@talevy
Copy link
Contributor Author

talevy commented Mar 17, 2021

More validation is likely necessary for rollups on agg-metric fields that fail, for example:

  • invalid interval is configured for a specific metric. This scenario will need to leverage the mapping meta fields for this information and resolution
  • invalid metrics. For example doing a max on a field with only an avg value.

@talevy talevy force-pushed the rollup-of-rollup branch from 714704c to 773c308 Compare March 18, 2021 05:27
@talevy talevy requested a review from jimczi March 18, 2021 16:52
this commit adds support for aggregate_metric_double fields
in the RollupShardIndexer.

Previously, rollups of rollups were failing because the indexer
did not know how to fetch field values for aggregate metric fields and
the respective _doc_count fields
@talevy
Copy link
Contributor Author

talevy commented Oct 20, 2021

closing due to staleness 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.13.5 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants