Avoid atomic overwrite tests on FS repositories #70483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we leniently permit overwrites of blobs in a repository not to be atomic, since they are not in shared filesystem repositories. In fact it's worse, on Windows overwrites do not even work if there is a concurrent reader. In practice this isn't very important, we do almost no overwrites and almost never read the file that's being overwritten, but we do still test for atomic overwrites in the repository analyzer. With this commit we suppress the atomic overwrite checks in the repository analyzer for FS repositories, and remove the lenience since all other repositories should implement atomic overwrites correctly. Closes elastic#70303
DaveCTurner
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
deleted the
2021-03-17-avoid-atomic-overwrite-tests-on-fs-repositories
branch
DaveCTurner
added a commit
that referenced
this pull request
Mar 22, 2021
Today we leniently permit overwrites of blobs in a repository not to be atomic, since they are not in shared filesystem repositories. In fact it's worse, on Windows overwrites do not even work if there is a concurrent reader. In practice this isn't very important, we do almost no overwrites and almost never read the file that's being overwritten, but we do still test for atomic overwrites in the repository analyzer. With this commit we suppress the atomic overwrite checks in the repository analyzer for FS repositories, and remove the lenience since all other repositories should implement atomic overwrites correctly. Closes #70303
DaveCTurner
added a commit
that referenced
this pull request
Mar 22, 2021
Today we leniently permit overwrites of blobs in a repository not to be atomic, since they are not in shared filesystem repositories. In fact it's worse, on Windows overwrites do not even work if there is a concurrent reader. In practice this isn't very important, we do almost no overwrites and almost never read the file that's being overwritten, but we do still test for atomic overwrites in the repository analyzer. With this commit we suppress the atomic overwrite checks in the repository analyzer for FS repositories, and remove the lenience since all other repositories should implement atomic overwrites correctly. Closes #70303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we leniently permit overwrites of blobs in a repository not to be
atomic, since they are not in shared filesystem repositories. In fact
it's worse, on Windows overwrites do not even work if there is a
concurrent reader. In practice this isn't very important, we do almost
no overwrites and almost never read the file that's being overwritten,
but we do still test for atomic overwrites in the repository analyzer.
With this commit we suppress the atomic overwrite checks in the
repository analyzer for FS repositories, and remove the lenience since
all other repositories should implement atomic overwrites correctly.
Closes #70303