Fix overflow in GeoTileGridTiler #70222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
approved these changes
Mar 10, 2021
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 11, 2021
This PR uses longs to compute the number of tiles touching a bounding box
iverase
added a commit
that referenced
this pull request
Mar 11, 2021
iverase
added a commit
that referenced
this pull request
Mar 11, 2021
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Mar 15, 2021
This PR uses longs to compute the number of tiles touching a bounding box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the number of tiles a bounding box might touch, we perform the calculation in integers which can overflow. In addition when calculating such value during rasterisation, we do not have into account the bounds in the bounded case, therefore we might overestimate the number of cells we might be touching.
This PR uses longs to compute the number of tiles touching a bounding box and bounds the value in the bounded case.