Add doc reference for client_auth_method #70124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for additional Client authentication methods was added in the OIDC realm in elastic#58708. This change adds the `rp.client_auth_method` in the realm settings reference doc.
jkakavas
added
>docs
elasticmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ywangd
reviewed
Mar 9, 2021
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
Should we also document rp.client_auth_jwt_signature_algorithm while we are here?
typo Co-authored-by: Yang Wang <[email protected]>
lcawl
reviewed
Mar 9, 2021
| // tag::rp-client-auth-method-tag[] | ||
| `rp.client_auth_method` {ess-icon}:: | ||
| (<<static-cluster-setting, Static>>) | ||
| The Client authentication method used by elasticsearch as a client to authenticate |
Contributor
There was a problem hiding this comment.
Feels one of the two occurrences of "client" is redundant:
Suggested change
| The Client authentication method used by elasticsearch as a client to authenticate | |
| The authentication method used by {es} as a client to authenticate |
Contributor
Author
There was a problem hiding this comment.
I'll change the {es} thanks ! but it's called "Client authentication" in OpenID Connect , so I will leave this here ( not capitalized)
lcawl
reviewed
Mar 9, 2021
| `rp.client_auth_signature_algorithm` {ess-icon}:: | ||
| (<<static-cluster-setting, Static>>) | ||
| The signature algorithm that {es} uses to sign the JWT with which it authenticates | ||
| as a Client to the OpenID Connect Provider when `client_secret_jwt` is selected for |
Contributor
There was a problem hiding this comment.
Unless this is a specific client that is always capitalized, I think it should be lowercase:
Suggested change
| as a Client to the OpenID Connect Provider when `client_secret_jwt` is selected for | |
| as a client to the OpenID Connect Provider when `client_secret_jwt` is selected for |
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 10, 2021
Support for additional Client authentication methods was added in the OIDC realm in elastic#58708. This change adds the `rp.client_auth_method` and `rp.client_auth_signature_algorithm` settings in the realm settings reference doc.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 10, 2021
Support for additional Client authentication methods was added in the OIDC realm in elastic#58708. This change adds the `rp.client_auth_method` and `rp.client_auth_signature_algorithm` settings in the realm settings reference doc.
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 10, 2021
Support for additional Client authentication methods was added in the OIDC realm in elastic#58708. This change adds the `rp.client_auth_method` and `rp.client_auth_signature_algorithm` settings in the realm settings reference doc.
This was referenced Mar 10, 2021
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Mar 10, 2021
Support for additional Client authentication methods was added in the OIDC realm in elastic#58708. This change adds the `rp.client_auth_method` and `rp.client_auth_signature_algorithm` settings in the realm settings reference doc.
jkakavas
added a commit
that referenced
this pull request
Mar 10, 2021
jkakavas
added a commit
that referenced
this pull request
Mar 10, 2021
jkakavas
added a commit
that referenced
this pull request
Mar 10, 2021
jkakavas
added a commit
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for additional Client authentication methods was added in
the OIDC realm in #58708. This change adds the
rp.client_auth_methodin the realm settings reference doc.