Reduce state size in awareness allocation decider #70063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the awareness allocation decider computes the number of nodes and shards in each zone, even though it only needs to know the names of the zones and the number of shards in the current zone. This commit drops the unnecessary state in the computation.
DaveCTurner
added
:Distributed Coordination/Allocation
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Mar 9, 2021
| } | ||
| final RoutingNode currentNode = allocation.routingNodes().node( | ||
| shardRouting.relocating() ? shardRouting.relocatingNodeId() : shardRouting.currentNodeId()); | ||
| if (currentAttributeValue.equals(currentNode.node().getAttributes().get(awarenessAttribute)) == false) { |
Contributor
There was a problem hiding this comment.
nit: Can we perhaps rename currentAttributeValue and shardsForCurrentAttributeValue to something like targetAttributeValue and shardsForTargetAttributeValue? That would help distinguish currentNode and currentAttributeValue (which are from different nodes).
DaveCTurner
added a commit
that referenced
this pull request
Mar 16, 2021
Today the awareness allocation decider computes the number of nodes and shards in each zone, even though it only needs to know the names of the zones and the number of shards in the current zone. This commit drops the unnecessary state in the computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the awareness allocation decider computes the number of nodes and
shards in each zone, even though it only needs to know the names of the
zones and the number of shards in the current zone. This commit drops
the unnecessary state in the computation.