Add custom metadata to track node shutdowns #70044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a basic class to iterate on, plus tests.
22 tasks
dakrone
approved these changes
Mar 15, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM I left one minor comment, thanks Gordon
| /** | ||
| * Contains data about a single node's shutdown readiness. | ||
| */ | ||
| public class SingleNodeShutdownMetadata extends AbstractDiffable<SingleNodeShutdownMetadata> |
Member
There was a problem hiding this comment.
I suggest we also add node_name to this, because the human readable name is probably the most handy way folks can reference the nodes
gwbrown
added
v7.13.0
v8.0.0
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
dakrone
requested changes
Mar 23, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
Thanks Gordon! I left some comments
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/SingleNodeShutdownMetadata.java
Outdated
Show resolved
Hide resolved
gwbrown
added
:Core/Infra/Node Lifecycle
dakrone
approved these changes
Mar 24, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left two really minor nits, but no need for another review!
server/src/main/java/org/elasticsearch/cluster/metadata/NodeShutdownComponentStatus.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/NodeShutdownComponentStatus.java
Show resolved
Hide resolved
gwbrown
added a commit
that referenced
this pull request
Mar 29, 2021
The node shutdown metadata is not hooked up to any APIs or logic as of this PR, this is just the data structures and associated tests.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Mar 29, 2021
This commit updates the serialization verion used for node shutdown metadata following the backport of elastic#70044.
gwbrown
added a commit
that referenced
this pull request
Mar 30, 2021
This commit updates the serialization verion used for node shutdown metadata following the backport of #70044. Also re-enables BWC tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node shutdown metadata is not hooked up to any APIs or logic as of this PR, this is just the data structures and associated tests.
Relates #70338