Async Processors and Final Pipelines are Broken #69818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an obvious race here where async processor and final pipeline will run concurrently.
original-brownbear
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
DaveCTurner
reviewed
Mar 2, 2021
server/src/internalClusterTest/java/org/elasticsearch/index/FinalPipelineIT.java
Outdated
Show resolved
Hide resolved
probakowski
approved these changes
Mar 3, 2021
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this @original-brownbear!
I wondered if we can hit stack overflow in case of sync processors (we do recurse in that case) but I think it's not a problem here as it should have at most 2 items in it
Contributor
Author
|
Thanks @probakowski ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 3, 2021
There was an obvious race here where async processor and final pipeline will run concurrently (or the final pipeline runs multiple times in from the while loop). relates elastic#52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 3, 2021
There was an obvious race here where async processor and final pipeline will run concurrently (or the final pipeline runs multiple times in from the while loop). relates elastic#52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)
original-brownbear
added a commit
that referenced
this pull request
Mar 3, 2021
There was an obvious race here where async processor and final pipeline will run concurrently (or the final pipeline runs multiple times in from the while loop). relates #52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)
original-brownbear
added a commit
that referenced
this pull request
Mar 3, 2021
There was an obvious race here where async processor and final pipeline will run concurrently (or the final pipeline runs multiple times in from the while loop). relates #52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 4, 2021
There was an obvious race here where async processor and final pipeline will run concurrently (or the final pipeline runs multiple times in from the while loop). relates elastic#52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)
original-brownbear
added a commit
that referenced
this pull request
Mar 4, 2021
There was an obvious race here where async processor and final pipeline will run concurrently (or the final pipeline runs multiple times in from the while loop). relates #52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an obvious race here where async processor and final pipeline will
run concurrently (or the final pipeline runs multiple times in from the while loop).
relates #52339 (fixes one failure scenario here but since the failure also occurred in 7.10.x not all of them)