Add integration tests for filters #69439
Conversation
nik9000
added
>test
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Looks like we already covered a bunch of this in #27128. I'll see what I can merge. |
Revamps the integration tests for the `filter` agg to be more clear and builds integration tests for the `fitlers` agg. Both of these integration tests are fairly basic but they do assert that the aggs work.
I've merged the cache hitting tests into the |
|
|
||
| //there is something wrong when using dotted document syntax here, passes in main yaml tests | ||
| 'search/330_fetch_fields/Test nested field inside object structure', | ||
| 'search/330_fetch_fields/Test nested field inside object structure', |
|
I've tracked down the caching error. As of 10 days ago the version of the node that received the request is part of the cache key. If we're going to assert that we cache we'll need to be careful. I'll push an update in a bit. |
|
@imotov I believe this is ready for another round. The tests that were failing for me are are passing locally for me now. Let's see what Jenkins says about 'em. |
| throw new XContentParseException(parser.getTokenLocation(), "expected [version] to be a value"); | ||
| } | ||
| List<VersionRange> skipVersionRanges = SkipSection.parseVersionRanges(parser.text()); | ||
| List<VersionRange> skipVersionRanges = parser.text().equals("current") |
There was a problem hiding this comment.
I don't like current here, it was pretty confusing when I looked at it for the first time, but I cannot come up with anything better, and more I look at it, the more it makes sense 😄. I tried latest and same but they seem to be even more confusing.
There was a problem hiding this comment.
Version.CURRENT is the name of the constant. But, yeah, I get it. In the yaml context its weird.
There was a problem hiding this comment.
I'm going to merge this with current and hope that we can come up with a better name soon.
There was a problem hiding this comment.
It makes perfect sense in Version, since there is only one version that we are currently working with.
There was a problem hiding this comment.
I'm with you that it is weird. But all the alternatives I can think of are confusing too. latest, same, this_branch.
Revamps the integration tests for the `filter` agg to be more clear and builds integration tests for the `fitlers` agg. Both of these integration tests are fairly basic but they do assert that the aggs work.
Revamps the integration tests for the `filter` agg to be more clear and builds integration tests for the `fitlers` agg. Both of these integration tests are fairly basic but they do assert that the aggs work.
4 participants
Revamps the integration tests for the
filteragg to be more clear andbuilds integration tests for the
fitlersagg. Both of theseintegration tests are fairly basic but they do assert that the aggs
work.