Skip to content

Copy_from on set processor should deep copy non-primitive mutable types #69349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

Copy_from on set processor should deep copy non-primitive mutable types #69349

merged 2 commits into from
Mar 3, 2021

Conversation

danhermann
Copy link
Contributor

Fixes #69348

@danhermann danhermann added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.13.0 v7.12.1 labels Feb 22, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Feb 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann
Copy link
Contributor Author

@elasticmachine update branch

@danhermann
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

@jbaiera jbaiera self-requested a review February 25, 2021 16:32
jbaiera
jbaiera approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhermann danhermann merged commit 926dc4f into elastic:master Mar 3, 2021
@danhermann danhermann deleted the deep_copy_from branch March 3, 2021 13:09
@danhermann
Copy link
Contributor Author

Thank you, @jbaiera!

danhermann added a commit to danhermann/elasticsearch that referenced this pull request Mar 3, 2021
@danhermann
Set processor's copy_from should deep copy non-primitive mutable types (
a8d7429 
elastic#69349)
@danhermann danhermann mentioned this pull request Mar 3, 2021
Merged
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Mar 3, 2021
@danhermann
Set processor's copy_from should deep copy non-primitive mutable types (
5a0e8c2 
elastic#69349)
@danhermann danhermann mentioned this pull request Mar 3, 2021
Merged
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Mar 3, 2021
@danhermann
Set processor's copy_from should deep copy non-primitive mutable types (
f3d3db9 
elastic#69349)
@danhermann danhermann mentioned this pull request Mar 3, 2021
Merged
danhermann added a commit that referenced this pull request Mar 3, 2021
@danhermann
Set processor's copy_from should deep copy non-primitive mutable types (
99c50ee 
#69349) (#69871)
danhermann added a commit that referenced this pull request Mar 3, 2021
@danhermann
Set processor's copy_from should deep copy non-primitive mutable types (
cd1538f 
#69349) (#69872)
danhermann added a commit that referenced this pull request Mar 3, 2021
@danhermann
Set processor's copy_from should deep copy non-primitive mutable types (
e6e73c2 
#69349) (#69870)
This was referenced Mar 9, 2021
Merged
Merged
@danhermann danhermann mentioned this pull request Mar 12, 2021
Merged
@original-brownbear original-brownbear mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaiera jbaiera jbaiera approved these changes

Assignees
No one assigned
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v7.11.2 v7.12.1 v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copy_from option on set processor links rather than copies complex content
4 participants
@danhermann @elasticmachine @jbaiera @jakelandis