[ML] Do not add runtime section to DFA dest index mappings unnecessarily #69329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since config runtime mappings were added to data frame analytics jobs in elastic#69183, when we create the destination index we add a `runtime` section in its mappings regardless of whether the job config contains any runtime fields. This causes failures in the BWC tests when in a mixed cluster where there are nodes versioned before runtime fields were introduced. This is the first part of the fix were we do not create a `runtime` section in the destination index mappings unless necessary.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
dimitris-athanasiou
deleted the
do-not-add-runtime-mappings-if-dfa-job-does-not-have-any
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Feb 22, 2021
…essarily (elastic#69329) Since config runtime mappings were added to data frame analytics jobs in elastic#69183, when we create the destination index we add a `runtime` section in its mappings regardless of whether the job config contains any runtime fields. This causes failures in the BWC tests when in a mixed cluster where there are nodes versioned before runtime fields were introduced. This is the first part of the fix were we do not create a `runtime` section in the destination index mappings unless necessary. Backport of elastic#69329
dimitris-athanasiou
added a commit
that referenced
this pull request
Feb 22, 2021
…essarily (#69329) (#69332) Since config runtime mappings were added to data frame analytics jobs in #69183, when we create the destination index we add a `runtime` section in its mappings regardless of whether the job config contains any runtime fields. This causes failures in the BWC tests when in a mixed cluster where there are nodes versioned before runtime fields were introduced. This is the first part of the fix were we do not create a `runtime` section in the destination index mappings unless necessary. Backport of #69329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since config runtime mappings were added to data frame analytics jobs
in #69183, when we create the destination index we add a
runtimesection in its mappings regardless of whether the job config contains
any runtime fields. This causes failures in the BWC tests when in a
mixed cluster where there are nodes versioned before runtime fields
were introduced.
This is the first part of the fix were we do not create a
runtimesectionin the destination index mappings unless necessary.