Manually trigger local exporter to open a bulk in some monitor tests. #69139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change tests to use monitor bulk api on elected master node before verifying watcher index exists. Sometimes the monitor service on the elected master doesn't yet export monitor documents resulting in tests using the `ensureInitialLocalResources(...)` method to fail. Cluster alerts watcher are only installed when local exporter tries to resolve local bulk. Relates to elastic#66586
martijnvg
added
>test
elasticmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
|
@elasticmachine update branch |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Feb 22, 2021
…elastic#69139) Change tests to use monitor bulk api on elected master node before verifying watcher index exists. Sometimes the monitor service on the elected master doesn't yet export monitor documents resulting in tests using the `ensureInitialLocalResources(...)` method to fail. Cluster alerts watcher are only installed when local exporter tries to resolve local bulk. Relates to elastic#66586
martijnvg
added a commit
that referenced
this pull request
Feb 22, 2021
…69326) Re-enabled TransportMonitoringMigrateAlertsActionTests#testLocalAlertsRemoval and TransportMonitoringMigrateAlertsActionTests#testRepeatedLocalAlertsRemoval on 7.x branch. Includes changes from #69139 and #68752 Relates to #66586 Included commits: * Add more trace logging when installing monitor watches and (#68752) unmute TransportMonitoringMigrateAlertsActionTests#testLocalAlertsRemoval and TransportMonitoringMigrateAlertsActionTests#testRepeatedLocalAlertsRemoval tests Somehow during these tests the monitor watches are not installed. Both tests use the local exporter and this exporter only installs the watches under specific conditions via the elected master node. I suspect the conditions are never met. The http exporter is more relaxed when attempting to install monitor watches and the tests using the http exporter seem not to be prone by the fact that tests fail because monitor watches have not been installed. Relates to #66586 * Manually trigger local exporter to open a bulk in some monitor tests. (#69139) Change tests to use monitor bulk api on elected master node before verifying watcher index exists. Sometimes the monitor service on the elected master doesn't yet export monitor documents resulting in tests using the `ensureInitialLocalResources(...)` method to fail. Cluster alerts watcher are only installed when local exporter tries to resolve local bulk. Relates to #66586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change tests to use monitor bulk api on elected master node before verifying watcher index exists.
Sometimes the monitor service on the elected master doesn't yet export monitor documents resulting in tests using the
ensureInitialLocalResources(...)method to fail.Cluster alerts watcher are only installed when local exporter tries to resolve local bulk.
Relates to #66586