Skip to content

Fix issue with AnnotatedTextHighlighter and max_analyzed_offset #69028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix issue with AnnotatedTextHighlighter and max_analyzed_offset #69028

merged 1 commit into from
Feb 16, 2021

Conversation

@matriv
Copy link
Contributor

@matriv matriv commented Feb 16, 2021

With the newly introduced max_analyzed_offset the analyzer of
AnnotatedTextHighlighter was wrapped twice with the
LimitTokenOffsetAnalyzer by mistake.

Follows: #67325

@matriv matriv added the :Search Relevance/Highlighting How a query matched a document label Feb 16, 2021
@matriv matriv force-pushed the fix-annotated-highlighter branch from 4270bcd to 96e380f Compare February 16, 2021 13:20
@matriv
Fix issue with AnnotatedTextHighlighter and max_analyzed_offset
96378d6 
With the newly introduced `max_analyzed_offset` the analyzer of
`AnnotatedTextHighlighter` was wrapped twice with the
`LimitTokenOffsetAnalyzer` by mistake.

Follows: elastic#67325
@matriv matriv force-pushed the fix-annotated-highlighter branch from 96e380f to 96378d6 Compare February 16, 2021 13:39
@matriv matriv marked this pull request as ready for review February 16, 2021 13:40
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Feb 16, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 16, 2021

Pinging @elastic/es-search (Team:Search)

romseygeek
romseygeek approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 1e12c93 into elastic:master Feb 16, 2021
@matriv matriv deleted the fix-annotated-highlighter branch February 16, 2021 16:08
matriv added a commit that referenced this pull request Feb 16, 2021
@matriv
Fix issue with AnnotatedTextHighlighter and max_analyzed_offset (#69028…
aebfe1d 
…) (#69058)

With the newly introduced `max_analyzed_offset` the analyzer of
`AnnotatedTextHighlighter` was wrapped twice with the
`LimitTokenOffsetAnalyzer` by mistake.

Follows: #67325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romseygeek romseygeek romseygeek approved these changes

+1 more reviewer

@markharwood markharwood markharwood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Search Relevance/Highlighting How a query matched a document Team:Search Meta label for search team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matriv @elasticmachine @markharwood @romseygeek